Implement `core::arch::return_address` and tests by chorman0773 · Pull Request #154972 · rust-lang/rust

chorman0773 · 2026-04-07T23:25:45Z

Tracking issue: #154966

Implements libs-team#768

rustbot · 2026-04-07T23:25:49Z

Some changes occurred to the intrinsics. Make sure the CTFE / Miri interpreter
gets adapted for the changes, if necessary.

cc @rust-lang/miri, @RalfJung, @oli-obk, @lcnr

rustbot · 2026-04-07T23:25:51Z

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

Owners of files modified in this PR: @scottmcm, libs
@scottmcm, libs expanded to 8 candidates
Random selection from Mark-Simulacrum, jhpratt, scottmcm

chorman0773 · 2026-04-11T03:34:41Z

Helpful comment, thanks rustbot 😐

Mark-Simulacrum

I'm not a huge fan of the doc comment's language. Could you try iterating on it a bit?

I think adding the cranelift implementation in this PR would also make sense (and maybe a gcc backend implementation -- not sure how easy that is?).

r=me with at least the comment fixed.

View changes since this review

rustbot · 2026-04-11T16:12:37Z

Reminder, once the PR becomes ready for a review, use @rustbot ready.

rustbot · 2026-04-13T18:48:34Z

Some changes occurred in compiler/rustc_codegen_cranelift

cc @bjorn3

chorman0773 · 2026-04-13T18:50:24Z

I've changed the wording of the comment arround a bit, in part to make it more clear than returning null is something the compiler tries to do if it can't return a useful value for some reason, but doesn't guarantee. I've also added a cranelift impl. I'll figure out gcc/miri in a future PR.

r=@Mark-Simulacrum

@rustbot ready

Mark-Simulacrum · 2026-04-18T20:15:27Z

r=me with commits squashed

r? me

* Implement core::arch::return_address and tests Fix typo Apply suggestions from code review Wording/docs changes. Co-authored-by: Ralf Jung <post@ralfj.de> Change signature according to Ralf's comment Fix call to `core::intrinsics::return_address()` according to the new signature Add cranelift implementation for intrinsic Change wording on `return_address!()` to be clear that returning a null pointer is best-effort. Fix formatting of doc comment Fix mistake in cranelift codegen * Do not generate llvm.returnaddress on wasm * Supress return_address test on miri

rust-bors · 2026-04-26T11:56:52Z

🔨 3 commits were squashed into 4b5d544.

Mark-Simulacrum · 2026-04-26T12:05:45Z

@bors r+

rust-bors · 2026-04-26T12:05:48Z

📌 Commit 4b5d544 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

…-Simulacrum Implement `core::arch::return_address` and tests Tracking issue: rust-lang#154966 Implements libs-team#768

JonathanBrouwer · 2026-04-26T15:06:43Z

@bors r-
#155824 (comment)
(please run a try job for x86_64-gnu-aux before r+'ing)

rust-bors · 2026-04-26T15:06:50Z

This pull request was unapproved.

This PR was contained in a rollup (#155824), which was unapproved.

View changes since this unapproval

chorman0773 · 2026-05-03T00:56:21Z

I don't think I can run try, so I'm just going to ready.

@rustbot ready

RalfJung · 2026-05-03T08:00:38Z

@bors try jobs=x86_64-gnu-aux

Implement `core::arch::return_address` and tests try-job: x86_64-gnu-aux

rust-bors · 2026-05-03T10:05:41Z

💔 Test for 4c27a6c failed: CI. Failed job:

try - x86_64-gnu-aux (web logs, enhanced plaintext logs)

RalfJung · 2026-05-03T17:42:24Z

@bors try jobs=x86_64-gnu-aux

Implement `core::arch::return_address` and tests try-job: x86_64-gnu-aux

rust-bors · 2026-05-03T20:10:36Z

☀️ Try build successful (CI)
Build commit: 8d9d27a (8d9d27a2717522ee5481b673cd72a86424f62ad6, parent: 54f67d248b14af80be8f3adc2094dd4a84ec2115)

rustbot assigned Mark-Simulacrum Apr 7, 2026

chorman0773 mentioned this pull request Apr 7, 2026

Tracking Issue for core::arch::return_address #154966

Open

5 tasks

This comment has been minimized.

Sign in to view

bjorn3 reviewed Apr 8, 2026

View reviewed changes

Comment thread compiler/rustc_codegen_llvm/src/intrinsic.rs

RalfJung reviewed Apr 8, 2026

View reviewed changes

Comment thread library/core/src/intrinsics/mod.rs Outdated

RalfJung reviewed Apr 8, 2026

View reviewed changes

Comment thread library/core/src/arch.rs Outdated

RalfJung reviewed Apr 8, 2026

View reviewed changes

Comment thread library/core/src/intrinsics/mod.rs Outdated

This comment has been minimized.

Sign in to view

Mark-Simulacrum requested changes Apr 11, 2026

View reviewed changes

Comment thread library/core/src/arch.rs Outdated

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 11, 2026

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 13, 2026

Mark-Simulacrum reviewed Apr 18, 2026

View reviewed changes

Comment thread compiler/rustc_codegen_cranelift/src/intrinsics/mod.rs Outdated

rustbot assigned bjorn3 and unassigned Mark-Simulacrum Apr 18, 2026

rustbot assigned Mark-Simulacrum and unassigned bjorn3 Apr 18, 2026

chorman0773 force-pushed the return_address branch from 11bfbbc to d6da4ea Compare April 18, 2026 22:36

This comment has been minimized.

Sign in to view

rust-bors Bot force-pushed the return_address branch from ca052d0 to 4b5d544 Compare April 26, 2026 11:56

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 26, 2026

JonathanBrouwer mentioned this pull request Apr 26, 2026

Rollup of 7 pull requests #155824

Closed

rust-bors Bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 26, 2026

Fix cfg use for disabling test on miri

706d098

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 3, 2026

This comment has been minimized.

Sign in to view

rust-bors Bot pushed a commit that referenced this pull request May 3, 2026

Auto merge of #154972 - chorman0773:return_address, r=<try>

4c27a6c

Implement `core::arch::return_address` and tests try-job: x86_64-gnu-aux

rust-bors Bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 3, 2026

This comment has been minimized.

Sign in to view

Final attempt at making miri work

c876de4

This comment has been minimized.

Sign in to view

rust-bors Bot pushed a commit that referenced this pull request May 3, 2026

Auto merge of #154972 - chorman0773:return_address, r=<try>

8d9d27a

Implement `core::arch::return_address` and tests try-job: x86_64-gnu-aux

Uh oh!

Conversation

chorman0773 commented Apr 7, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Apr 7, 2026

Uh oh!

rustbot commented Apr 7, 2026

Uh oh!

This comment has been minimized.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment has been minimized.

chorman0773 commented Apr 11, 2026

Uh oh!

Mark-Simulacrum left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

rustbot commented Apr 11, 2026

Uh oh!

rustbot commented Apr 13, 2026

Uh oh!

chorman0773 commented Apr 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Mark-Simulacrum commented Apr 18, 2026

Uh oh!

This comment has been minimized.

rust-bors Bot commented Apr 26, 2026

Uh oh!

Mark-Simulacrum commented Apr 26, 2026

Uh oh!

rust-bors Bot commented Apr 26, 2026

Uh oh!

JonathanBrouwer commented Apr 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rust-bors Bot commented Apr 26, 2026

Uh oh!

chorman0773 commented May 3, 2026

Uh oh!

RalfJung commented May 3, 2026

Uh oh!

This comment has been minimized.

rust-bors Bot commented May 3, 2026

Uh oh!

This comment has been minimized.

RalfJung commented May 3, 2026

Uh oh!

This comment has been minimized.

rust-bors Bot commented May 3, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

chorman0773 commented Apr 7, 2026 •

edited by rustbot

Loading

Mark-Simulacrum left a comment •

edited by rustbot

Loading

chorman0773 commented Apr 13, 2026 •

edited

Loading

JonathanBrouwer commented Apr 26, 2026 •

edited

Loading